Limit number of hops #1928
Limit number of hops #1928
Conversation
This reverts commit b074827.
DavIvek
force-pushed
the
limit-number-of-hops
branch
from
f13a057
to
b074827
Compare
This reverts commit 0bb0363.
src/query/interpreter.cpp
Outdated
| if (!flags::run_time::GetHopsLimitPartialResults() && (ctx_.hops_limit.has_value() && ctx_.hops_limit.value() < 0)) { | ||
| throw QueryException("Query exceeded the maximum number of hops."); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think it's better maybe to make an object in the context with the value that's maximum, and the current value, so we can ask the object if the hops limit is in place and if the hops limit is exhausted, rather than modifying this limit in place
src/query/interpreter.cpp
Outdated
| // TODO: how to expose metrics when we have hops limit? | ||
| const auto hops_limit = EvaluateHopsLimit(evaluator, cypher_query->hops_limit_); |
There was a problem hiding this comment.
can you elaborate this question, I don't understand it at the moment?
There was a problem hiding this comment.
I think that comment isn't relevant anymore. Something that bothered me before -> should have delete it before review.
| continue; | ||
| in_edges.emplace_back(edge_type, from_vertex, edge); | ||
| expanded_count = static_cast<int64_t>(vertex_->in_edges.size()); | ||
| // TODO: a better filter copy |
There was a problem hiding this comment.
what is a better filter copy?
There was a problem hiding this comment.
That comment isn't placed here by me. Was here before but since I changed this file it looks like I have put it.
I also don't get it, maybe we can delete it.
|
Description
Syntax:
USING HOPS LIMIT xPR for hops counting: #1935.
Count (Measure and expose hops back to the user (BFS+DFS+Expand; if an edge is filtered out, it should count as a hop).
How to count hops → each time an edge is “crossed”, it’s counted as a HOP.
NOTE: Different cursor will return different paths due to different implementations. Hops are counted in the same way for every cursor.
[master < Task] PR
Documentation checklist
closes #1374