Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added home-plug icon #2123

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented May 3, 2024

closes #1855

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Icon use case

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Added or changed icons

icons/home-plug.svg

Preview cohesion icons/rotate-ccw-square.svg
icons/home-plug.svg
icons/circle-pause.svg
Preview stroke widths icons/home-plug.svg
icons/home-plug.svg
icons/home-plug.svg
DPI Preview (24px) icons/home-plug.svg
Icon X-rays icons/home-plug.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const HomePlugIcon = createLucideIcon('HomePlug', [
  ["path",{"d":"M10 12V8.964"}],
  ["path",{"d":"M14 12V8.964"}],
  ["path",{"d":"M15 12a1 1 0 0 1 1 1v2a2 2 0 0 1-2 2h-4a2 2 0 0 1-2-2v-2a1 1 0 0 1 1-1z"}],
  ["path",{"d":"M8.5 21H5a2 2 0 0 1-2-2v-9a2 2 0 0 1 .709-1.528l7-5.999a2 2 0 0 1 2.582 0l7 5.999A2 2 0 0 1 21 10v9a2 2 0 0 1-2 2h-5a2 2 0 0 1-2-2v-2"}]
])

icons/home-plug.json Outdated Show resolved Hide resolved
jguddas and others added 2 commits May 3, 2024 17:28
Co-authored-by: Karsa <contact@karsa.org>
@karsa-mistmere
Copy link
Member

The plug is also build from scratch but maybe that's not a good thing.

Yeah, maybe we should keep this consistent with plug-zap and update both (top row current, bottom row proposal):
image

@jguddas
Copy link
Member Author

jguddas commented May 3, 2024

The plug is also build from scratch but maybe that's not a good thing.

Yeah, maybe we should keep this consistent with plug-zap and update both (top row current, bottom row proposal): image

What about doing something even crazier and removing plug-zap-2 entirely in favor of just having plug-zap?
I don't like the plug-zap-2 zap, it's to small.

@karsa-mistmere
Copy link
Member

The plug is also build from scratch but maybe that's not a good thing.

Yeah, maybe we should keep this consistent with plug-zap and update both (top row current, bottom row proposal): image

What about doing something even crazier and removing plug-zap-2 entirely in favor of just having plug-zap? I don't like the plug-zap-2 zap, it's to small.

Yeah, I also hate it, I've tried pushing this exact thing through several times already. 😶

@jguddas
Copy link
Member Author

jguddas commented May 3, 2024

The plug is also build from scratch but maybe that's not a good thing.

Yeah, maybe we should keep this consistent with plug-zap and update both (top row current, bottom row proposal): image

What about doing something even crazier and removing plug-zap-2 entirely in favor of just having plug-zap? I don't like the plug-zap-2 zap, it's to small.

Yeah, I also hate it, I've tried pushing this exact thing through several times already. 😶

@ericfennis are you up for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request]: Energy Autarky for house
2 participants