Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): redesigned home icon #2116

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented May 2, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Redesigned home icon

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Added or changed icons

icons/home.svg

Preview cohesion icons/message-square-share.svg
icons/home.svg
icons/ferris-wheel.svg
Preview stroke widths icons/home.svg
icons/home.svg
icons/home.svg
DPI Preview (24px) icons/home.svg
Icon X-rays icons/home.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const HomeIcon = createLucideIcon('Home', [
  ["path",{"d":"M15 21v-8a1 1 0 0 0-1-1h-4a1 1 0 0 0-1 1v8"}],
  ["path",{"d":"M3 10a2 2 0 0 1 .709-1.528l7-5.999a2 2 0 0 1 2.582 0l7 5.999A2 2 0 0 1 21 10v9a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2z"}]
])

@jguddas
Copy link
Member Author

jguddas commented May 3, 2024

What makes the curved door feel weird to you @karsa-mistmere?
Looks pretty neat at 12x to me.
Frame

icons/home.svg Outdated Show resolved Hide resolved
@karsa-mistmere
Copy link
Member

Also up for discussion: should we rename this to house?

@karsa-mistmere
Copy link
Member

karsa-mistmere commented May 3, 2024

What makes the curved door feel weird to you @karsa-mistmere? Looks pretty neat at 12x to me. Frame

To me that looks awful, I very much prefer the right one:

image


Edit: I know now why exactly this is bugging me – adding rounding that's invisible at our default settings means that scaled/light icons are fundamentally different, I think this is definitely undesirable.

@ericfennis
Copy link
Member

Can we also take a look at #1841 before we merge this one.

Other related issues:

@karsa-mistmere
Copy link
Member

Can we also take a look at #1841 before we merge this one.

Other related issues:

@jguddas already designed this very cute icon at #2123 for the autarky use case

As for home-plus (or should it not be house-plus?), I think these are our best candidates:
image

None of them spark joy, but it should definitely not be the last one.

@jguddas
Copy link
Member Author

jguddas commented May 3, 2024

Can we also take a look at #1841 before we merge this one.
Other related issues:

@jguddas already designed this very cute icon at #2123 for the autarky use case

As for home-plus (or should it not be house-plus?), I think these are our best candidates: image

None of them spark joy, but it should definitely not be the last one.

The second one with the plus in the roof looks nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants