Install lua dependencies via apt instead of luarocks. #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanholm
force-pushed
the
aidanholm-patch-2
branch
from
2f41319
to
b5a9635
Compare
This avoids installing luarocks, which has a few extra deps of its own. These apt packages contain four copies, for lua 5.1 through 5.4, but that should be much less expensive than installing luarocks and its deps.
aidanholm
force-pushed
the
aidanholm-patch-2
branch
from
b5a9635
to
7d96023
Compare
|
Yep that's better. It also resembles the setup that debian/ubuntu users have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids installing luarocks, which has a few extra deps of its own.
These apt packages contain four copies, for lua 5.1 through 5.4, but that should be much less expensive.