Install missing dependencies for tests.yml #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanholm
force-pushed
the
aidanholm-patch-1
branch
11 times, most recently
from
d6fee51
to
5e68746
Compare
|
Oh if the CI setup can run again, that would be amazing. |
aidanholm
force-pushed
the
aidanholm-patch-1
branch
3 times, most recently
from
4395402
to
81117ff
Compare
This adds basic coverage only -- e.g. non-luajit is not covered (and should be), as well as other Linux distributions. `make` and `make run-tests` are separated into separate steps so that the build output (which is pretty verbose) can be collapsed separately. The Github Actions builders are currently using Ubuntu 22.04 LTS, which contains a slightly older glib without the `G_APPLICATION_DEFAULT_FLAGS` symbol; turns out a conditional check was already there but was slightly off, so fixing that in passing.
aidanholm
force-pushed
the
aidanholm-patch-1
branch
from
81117ff
to
c4d0532
Compare
|
Should be ready :) This only covers the luajit + ubuntu combo, would be good to get some more up, but at least the tests will run with every commit / PR |
c0dev0id
reviewed
Feb 8, 2024
| #if GTK_CHECK_VERSION(2,74,0) | ||
| #if GLIB_CHECK_VERSION(2,74,0) |
There was a problem hiding this comment.
Unrelated to the PR, but good catch.
c0dev0id
reviewed
Feb 8, 2024
Comment on lines
+22
to
+24
| sudo luarocks --lua-version 5.1 install luafilesystem | ||
| sudo luarocks --lua-version 5.1 install luassert | ||
| sudo luarocks --lua-version 5.1 install luacheck |
There was a problem hiding this comment.
Why from luarocks and not via apt? lua-check lua-luassert lua-filesystem are available for lua 5.1 and my debian machine here. So I assume they are available here too. Or not?
There was a problem hiding this comment.
Ah, the reason is that I simply forgot about that possibility :) sent #1077
c0dev0id
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.