Skip to content

Commit

Permalink
Get basic Github CI working.
Browse files Browse the repository at this point in the history
This adds basic coverage only -- e.g. non-luajit is not covered (and
should be), as well as other Linux distributions.

`make` and `make run-tests` are separated into separate steps so that
the build output (which is pretty verbose) can be collapsed separately.

The Github Actions builders are currently using Ubuntu 22.04 LTS, which
contains a slightly older glib without the `G_APPLICATION_DEFAULT_FLAGS`
symbol; turns out a conditional check was already there but was slightly
off, so fixing that in passing.
  • Loading branch information
aidanholm committed Feb 8, 2024
1 parent 22b6af6 commit 2c5f90d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 11 additions & 0 deletions .github/workflows/tests.yml
Expand Up @@ -13,5 +13,16 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Install depenencies
run: |
sudo apt-get update
sudo apt-get install luajit libluajit-5.1-dev libjavascriptcoregtk-4.0-dev libwebkit2gtk-4.1-dev libgtk-3-dev libglib2.0-dev luarocks
- name: Install lua dependencies
run: |
sudo luarocks --lua-version 5.1 install luafilesystem
sudo luarocks --lua-version 5.1 install luassert
sudo luarocks --lua-version 5.1 install luacheck
- name: make
run: make
- name: make run-tests
run: make run-tests
2 changes: 1 addition & 1 deletion clib/unique.c
Expand Up @@ -78,7 +78,7 @@ luaH_unique_new(lua_State *L)

GError *error = NULL;
if (!globalconf.application) {
#if GTK_CHECK_VERSION(2,74,0)
#if GLIB_CHECK_VERSION(2,74,0)
globalconf.application = gtk_application_new(name, G_APPLICATION_DEFAULT_FLAGS);
#else
globalconf.application = gtk_application_new(name, G_APPLICATION_FLAGS_NONE);
Expand Down

0 comments on commit 2c5f90d

Please sign in to comment.