Add a global FreezeFS setting and a volume FreezeFS field #2744
+299
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is now in conflict. Could you fix it @ejweber? 🙏 |
|
This pull request is now in conflict. Could you fix it @ejweber? 🙏 |
|
I ran out of time to retest this now that the dependencies are resolved and coming from the lower-level merged PRs, but I don't anticipate any change in functionality. It is ready for review (and I will retest the full stack before merge). |
Longhorn 2187 Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber
force-pushed
the
2187-fsfreeze
branch
2 times, most recently
from
b5e5b7f
to
f3c4451
Compare
|
I retested the full stack and everything is looking good. Please review when you can. |
PhanLe1010
reviewed
May 31, 2024
PhanLe1010
reviewed
May 31, 2024
PhanLe1010
reviewed
May 31, 2024
PhanLe1010
reviewed
May 31, 2024
Longhorn 2187 Signed-off-by: Eric Weber <eric.weber@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#2187
What this PR does / why we need it:
freezeFS == trueorfreezeFS == falsein the proxy snapshot request to the engine.Depends on:
Need to resolve imports before merging.