Add FreezeFSForSnapshot support #719
Open
+337
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
reviewed
Apr 30, 2024
src/routes/volume/UpdateBulkFreezeFilesystemForSnapshotModal.js
Outdated
Show resolved
Hide resolved
a110605
reviewed
Apr 30, 2024
a110605
previously approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Overall LTGM 👍
Does this PR need to wait for longhorn/longhorn-manager#2744 merge first?
Longhorn 2187 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 2187 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 2187 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 2187 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 2187 Signed-off-by: Eric Weber <eric.weber@suse.com>
|
Made the changes suggested by @a110605 and rebased. This DOES need to wait on longhorn/longhorn-manager#2744 before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longhorn/longhorn#2187
Make the volume-specific FreezeFSForSnapshot setting configurable via the UI.
Depends on longhorn/longhorn-manager#2744.