Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v2 volume offline rebuilding #2743

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8442

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

Longhorn 8442

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 8442

Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit derekbit marked this pull request as ready for review April 25, 2024 16:12
@innobead
Copy link
Member

image

stuck? cc @FrankYang0529

@derekbit branch protection needs to be updated. Derek, please help update each repo after @FrankYang0529 replaces drone with github action.

image

innobead
innobead previously approved these changes Apr 26, 2024
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we need to remove the setting resource as well? or just leave it as w/o any effect?

@derekbit
Copy link
Member Author

LGTM.

Do we need to remove the setting resource as well? or just leave it as w/o any effect?

Retaining the setting is fine. Let me add it back.

Longhorn 8442

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 8442

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 8442

Signed-off-by: Derek Su <derek.su@suse.com>
@innobead innobead merged commit 7356c4f into longhorn:master Apr 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants