Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Remove v2 volume offline rebuilding in Longhorn v1.7 #8442

Open
derekbit opened this issue Apr 25, 2024 · 4 comments
Open

[TASK] Remove v2 volume offline rebuilding in Longhorn v1.7 #8442

derekbit opened this issue Apr 25, 2024 · 4 comments
Assignees
Labels
area/v2-data-engine v2 data engine (SPDK) area/volume-replica-rebuild Volume replica rebuilding related component/longhorn-manager Longhorn manager (control plane) kind/task General task request to fulfill another primary request
Milestone

Comments

@derekbit
Copy link
Member

derekbit commented Apr 25, 2024

What's the task? Please describe

After discussing with @shuo-wu , there are some changes in the rebuilding related SPDK APIs. To make the integration of delta rebuilding simpler, we will remove v2 volume offline rebuilding in v1.7.0.

Offline rebuilding is still useful for some scenarios. We can add it back after settling down the design and the implementation of delta rebuilding.

Describe the sub-tasks

Additional context

@derekbit derekbit added component/longhorn-manager Longhorn manager (control plane) kind/task General task request to fulfill another primary request area/v2-data-engine v2 data engine (SPDK) area/volume-replica-rebuild Volume replica rebuilding related labels Apr 25, 2024
@derekbit derekbit added this to the v1.7.0 milestone Apr 25, 2024
@derekbit derekbit self-assigned this Apr 25, 2024
@derekbit
Copy link
Member Author

cc @shuo-wu @DamiaSan

@innobead
Copy link
Member

Let's have another issue for adding offline rebuilding back and add it to 1.8.0.

@derekbit derekbit changed the title [TASK] Remove v2 volume offline rebuilding [TASK] Remove v2 volume offline rebuilding in Longhorn v1.7 Apr 25, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Apr 26, 2024

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

Shouldn't impact the regression test.

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2743

  • Which areas/issues this PR might have potential impacts on?
    Area: v2 volume, offline rebuild
    Issues

@DamiaSan
Copy link
Contributor

To make the integration of delta rebuilding simpler, we will remove v2 volume offline rebuilding in v1.7.0.

Do you mean online rebuilding instead delta rebuilding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2-data-engine v2 data engine (SPDK) area/volume-replica-rebuild Volume replica rebuilding related component/longhorn-manager Longhorn manager (control plane) kind/task General task request to fulfill another primary request
Projects
None yet
Development

No branches or pull requests

4 participants