Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [DI-18311] - Adding CloudPulse section to Cloud Manager #10397

Merged

Conversation

santoshp210
Copy link
Contributor

Description πŸ“

Added a CloudPulseTab component
Added a dashboard landing component
Added a RegionSelect component
Added a TimeRange component
Added a Global Filters component to manage the filters

Changes πŸ”„

List any change relevant to the reviewer.

  • Added a CloudPulseTab component
  • Added a dashboard landing component
  • Added a RegionSelect component
  • Added a TimeRange component
  • Added a Global Filters component to manage the filters

Preview πŸ“·

Include a screenshot or screen recording of the change

πŸ’‘ Use <video src="" /> tag when including recordings in table.

Before After
Screenshot 2024-04-22 at 19 55 04 Screenshot 2024-04-23 at 17 52 03
Screenshot 2024-04-22 at 19 55 04 Screenshot 2024-04-23 at 17 51 51

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • Follow cloud manager standard procedures

Reproduction steps

(How to reproduce the issue, if applicable)

  • N/A

Verification steps

(How to verify changes)

  • Navigate to cloud manager and once feature flag of CloudPulse is enabled then navigate to the Monitor section in the sidebar for the CloudPulse section.
  • There the added two global filters options are visible, can be used to select the respective options for both the RegionSelect and TimeRange

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@santoshp210 santoshp210 requested a review from a team as a code owner April 23, 2024 12:31
@santoshp210 santoshp210 requested review from bnussman-akamai and hkhalil-akamai and removed request for a team April 23, 2024 12:31
@mjac0bs mjac0bs added the UX/UI Changes for UI/UX to review label Apr 23, 2024
@bnussman-akamai bnussman-akamai changed the title [DI-18311] - Adding CloudPulse section to Cloud Manager upcoming: [DI-18311] - Adding CloudPulse section to Cloud Manager Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

Coverage Report: βœ…
Base Coverage: 82.28%
Current Coverage: 82.29%

@abailly-akamai abailly-akamai added CloudPulse and removed UX/UI Changes for UI/UX to review labels Apr 23, 2024
Copy link

@gitkcosby gitkcosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I approve this I need some context.

Are you just stubbing this in? If you are, this is fine, with the exception of changing the "2024" value in the time drop down to "Year to date".

If you're not stubbing this in, I need to see the UX design you're referencing, because what you have is pretty rough.

@kmuddapo
Copy link

kmuddapo commented Apr 25, 2024

Before I approve this I need some context.

Are you just stubbing this in? If you are, this is fine, with the exception of changing the "2024" value in the time drop down to "Year to date".

If you're not stubbing this in, I need to see the UX design you're referencing, because what you have is pretty rough.

For the 1st phase we are going with basic user journey functionalities utilizing the cloud manager components. This eventually will have a revised versions as we progressed. Regarding the dates, we will remove the years from that, as we will support only max of 30 days duration only

@santoshp210
Copy link
Contributor Author

Thank you, @jaalah-akamai .Can I mark those conversations as resolved ?

@jdamore-linode
Copy link
Contributor

@santoshp210 Just a heads up that merging in the latest changes from develop should resolve your test failure

…-global-filters

Merging the latest develop changes to resolve test failure
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and for addressing feedback!

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label May 30, 2024
@jaalah-akamai jaalah-akamai merged commit 1a1067b into linode:develop May 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! CloudPulse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants