-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DI-18311] - Add CloudPulse feature flag and landing page to Cloud Manager #10393
upcoming: [DI-18311] - Add CloudPulse feature flag and landing page to Cloud Manager #10393
Conversation
β¦moving unused Component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're just stubbing this in, it's fine. If not, there are some issues, such as the left nav saying "Monitor" and the page title saying "Akamai Cloud Pulse".
The nav saying "Monitor" and page saying "Akamai Cloud Pulse" is intentional as per our Product Manager and UI mockups. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new additions @santoshp210.
I confirmed the feature flag is present in the dev tools and the new landing primary nav entry routes to the new landing page. We'll need to fix the primary nav so the Monitor menu item respects the dev tools feature flag toggle. I also left some questions about the flag.
I'm not sure what your e2e testing plan is for building this feature out, but we will ask for test coverage of the overall flow. To start, that can be something as simple as testing the page navigation works and can be built out as the feature develops. (Example: loadbalancer-landing-page.spec.ts
)
packages/manager/.changeset/pr-10393-upcoming-features-1713795855499.md
Outdated
Show resolved
Hide resolved
Coverage Report: β
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates - this looks really close to being ready to merge. I'll approve this once merge conflicts are resolved and I left a couple of small suggestions about using the flag value to determine the visibility of the beta chip in the primary nav.
@santoshp210 Please merge in the latest from |
Hi @mjac0bs , resolved the commits for those files. |
Description π
Added cloudpulse section to cloud manager
Added feature flag control for cloudpulse section
Added an empty paper component in the cloudpulse section
Changes π
List any change relevant to the reviewer.
-Added cloudpulse section cloud manager
-Added feature flag control for cloudpulse section
-Added empty paper component in the cloudpulse section
Preview π·
Include a screenshot or screen recording of the change
π‘ Use
<video src="" />
tag when including recordings in table.|
How to test π§ͺ
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered π€
Check all that apply