Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [DI-18311] - Add CloudPulse feature flag and landing page to Cloud Manager #10393

Merged

Conversation

santoshp210
Copy link
Contributor

@santoshp210 santoshp210 commented Apr 22, 2024

Description πŸ“

Added cloudpulse section to cloud manager
Added feature flag control for cloudpulse section
Added an empty paper component in the cloudpulse section

Changes πŸ”„

List any change relevant to the reviewer.
-Added cloudpulse section cloud manager
-Added feature flag control for cloudpulse section
-Added empty paper component in the cloudpulse section

Preview πŸ“·

Include a screenshot or screen recording of the change

πŸ’‘ Use <video src="" /> tag when including recordings in table.

Before After
Screenshot 2024-04-22 at 18 04 10 image

|

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • Follow cloud manager standard procedures

Reproduction steps

(How to reproduce the issue, if applicable)

  • N/A

Verification steps

(How to verify changes)

  • Navigate to cloud manager and once feature flag of CloudPulse is enabled then navigate to the Monitor section in the sidebar for the CloudPulse section.

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@santoshp210 santoshp210 requested a review from a team as a code owner April 22, 2024 12:49
@santoshp210 santoshp210 requested review from bnussman-akamai and hana-linode and removed request for a team April 22, 2024 12:49
@mjac0bs mjac0bs added Wait to Merge UX/UI Changes for UI/UX to review labels Apr 22, 2024
@abailly-akamai abailly-akamai added CloudPulse and removed UX/UI Changes for UI/UX to review labels Apr 23, 2024
Copy link

@gitkcosby gitkcosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're just stubbing this in, it's fine. If not, there are some issues, such as the left nav saying "Monitor" and the page title saying "Akamai Cloud Pulse".

@santoshp210
Copy link
Contributor Author

If you're just stubbing this in, it's fine. If not, there are some issues, such as the left nav saying "Monitor" and the page title saying "Akamai Cloud Pulse".

The nav saying "Monitor" and page saying "Akamai Cloud Pulse" is intentional as per our Product Manager and UI mockups.

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new additions @santoshp210.

I confirmed the feature flag is present in the dev tools and the new landing primary nav entry routes to the new landing page. We'll need to fix the primary nav so the Monitor menu item respects the dev tools feature flag toggle. I also left some questions about the flag.

I'm not sure what your e2e testing plan is for building this feature out, but we will ask for test coverage of the overall flow. To start, that can be something as simple as testing the page navigation works and can be built out as the feature develops. (Example: loadbalancer-landing-page.spec.ts)

packages/manager/src/dev-tools/FeatureFlagTool.tsx Outdated Show resolved Hide resolved
packages/manager/src/featureFlags.ts Outdated Show resolved Hide resolved
packages/manager/src/components/PrimaryNav/PrimaryNav.tsx Outdated Show resolved Hide resolved
@mjac0bs mjac0bs changed the title upcoming: [DI-18311] - Adding CloudPulse section to Cloud Manager upcoming: [DI-18311] - Add CloudPulse feature flag and landing page to Cloud Manager Apr 26, 2024
Copy link

github-actions bot commented Apr 26, 2024

Coverage Report: βœ…
Base Coverage: 81.52%
Current Coverage: 81.52%

@mjac0bs mjac0bs self-requested a review May 14, 2024 21:50
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates - this looks really close to being ready to merge. I'll approve this once merge conflicts are resolved and I left a couple of small suggestions about using the flag value to determine the visibility of the beta chip in the primary nav.

packages/manager/src/featureFlags.ts Outdated Show resolved Hide resolved
packages/manager/src/components/PrimaryNav/PrimaryNav.tsx Outdated Show resolved Hide resolved
@mjac0bs
Copy link
Contributor

mjac0bs commented May 16, 2024

@santoshp210 Please merge in the latest from develop (you'll have to resolve the conflicts in MainContent, PrimaryNav, and featureFlags) and then CI should run and we can confirm this is good to go.

@santoshp210
Copy link
Contributor Author

Hi @mjac0bs , resolved the commits for those files.

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label May 20, 2024
@bnussman-akamai bnussman-akamai merged commit 6524907 into linode:develop May 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! CloudPulse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants