Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce StorageManager and an Hdfs Implementation for Storage #90

Merged
merged 2 commits into from Apr 29, 2024

Conversation

HotSushi
Copy link
Collaborator

@HotSushi HotSushi commented Apr 25, 2024

Summary

Laying foundations for storage part 3: StorageManager and an implementation for Hdfs: HdfsStorage.

StorageManager interface looks like

StorageManager {
  Storage getDefaultStorage()
  Storage getStorage(Type)
}

It runs through all configured Storages and returns the appropriate storage for default or for particular type.

HdfsStorage is yet another implementation for Storage similar to LocalStorage.
We've abstracted the common code for all storage-impls into BaseStorage

Changes

Testing Done

  • Added new tests for the changes made.

Copy link
Member

@abhisheknath2011 abhisheknath2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HotSushi . Added some comments.

jainlavina
jainlavina previously approved these changes Apr 26, 2024
Copy link
Collaborator

@jainlavina jainlavina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. But looks good otherwise.

Copy link
Member

@abhisheknath2011 abhisheknath2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing the comments/questions!

jainlavina
jainlavina previously approved these changes Apr 29, 2024
@HotSushi HotSushi merged commit 283d150 into linkedin:main Apr 29, 2024
1 check passed
@HotSushi HotSushi deleted the storage branch May 13, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants