-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce FileIOManager and FileIO implementations for HDFS and Local Storage #96
Conversation
...ernalcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/fileio/FileIOManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HotSushi for the PR. I have a few questions
...lcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/OpenHouseInternalCatalog.java
Show resolved
Hide resolved
...nalcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/fileio/ConfigureFileIO.java
Outdated
Show resolved
Hide resolved
...nalcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/fileio/ConfigureFileIO.java
Outdated
Show resolved
Hide resolved
...nalcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/fileio/ConfigureFileIO.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing major mainly naming
...nalcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/fileio/ConfigureFileIO.java
Outdated
Show resolved
Hide resolved
...ernalcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/fileio/FileIOManager.java
Show resolved
Hide resolved
LGTM. Looking forward to more information about cutover from old config to new config in PR description. It's not blocking though. |
Also please check why Build is failing |
Summary
Laying foundations for storage part 4:
FileIOManager
and FileIO implementations forHDFS
andLocal
FileIOManager interface looks like:
This interface is accompanied by
ConfigureFileIO
which sets up FileIOs for all "configured" storages.We do not replace the existing FileIO instances to ensure production systems do not break.
To learn the motivation behind these changes please see this doc
What's the next plan
Changes
Other related PRs:
Introduce StorageManager and an Hdfs Implementation for Storage #90
Add interfaces for StorageClient, Storage and its Implementation for Local #82
Add cluster.yaml, StorageProperties, StorageType enum for supporting multiple storages #76
Testing Done
we can observe logs like: