update dockerfile - maint/pre-hnn-core branch #338
Conversation
jashlu
changed the title
| RUN pip install hnn-core | ||
|
|
||
| RUN sudo apt-get update && \ | ||
| sudo apt-get install -y neuron-dev |
There was a problem hiding this comment.
Out of curiosity, is this preferred over doing a pip installation of NEURON?
There was a problem hiding this comment.
Just from experience I was having problems installing neuron with pip3, and so from some online resources (https://command-not-found.com/nrnivmodl) I tried an alternative and it worked
There was a problem hiding this comment.
Hmm, I've never run into issues using pip except on Windows (without WSL). NEURON doesn't currently distribute a python wheel for windows, but it should work for WSL, native linux, and macOS.
There was a problem hiding this comment.
This is the error I run into
=> ERROR [19/28] RUN sudo apt-get update && sudo apt-get install --no-install-recommends -y make gcc libc6-dev libtinfo-dev lib 11.0s
...
9.505 Processing triggers for libc-bin (2.31-0ubuntu9.12) ...
9.545 Cloning into '/home/hnn_user/hnn_source_code'...
10.82 nrnivmodl mod
10.82 make: nrnivmodl: Command not found
10.82 make: *** [Makefile:11: x86_64/special] Error 127
There was a problem hiding this comment.
To further clarify, I run into this error attempting to build the image on my mac
There was a problem hiding this comment.
I guess the "barebone" mac install in a docker is not the same as an actual mac computer ... there may be some compilers etc missing
|
@jashlu thanks for your work on this. Is it ready for a final review, or is there still more to do? |
|
I think the final decision was to just stick with the docker build for @dylansdaniels perhaps let's discuss in our next meeting updating the website documentation to make this clearer? right now people will be attempting to install a version of HNN-GUI that is fairly unstable as |
|
Just to clarify @jashlu, we went ahead and merged your recent docker build changes for |
Understood, thanks for the explanation. I will hold off on merging just for a bit while I work through adding the script to simplify one step in the xserver installation, I will tag you guys for re-review when it is done, should be done soon, thanks! |
|
I'll try to test this out on my windows machine this weekend. Feel free to bug me early next week if I don't get back to you soon @jashlu! |
That would be greatly appreciated, have a great weekend! |
|
@dylansdaniels I just noticed your comment in #337. Are you fetching from this branch? If not, I believe this the branch we ( |
|
So I was moreso referring to how if you follow the docker instructions in the pre-hnn-core branch, it will have you clone from hnn.git, which will put you on master branch. And then if you proceed to the next step in the instructions, it'll direct you to ./scripts/configure_vcxsrv.sh, but you won't be on the branch that has that file. |
Co-authored-by: Ryan Thorpe <ryan_thorpe@brown.edu>
|
Any other recommendations and/or concerns here @dylansdaniels? |
|
Sorry for the delay @rythorpe. That covers it in terms things I bumped into doing a fresh install on Windows 11 |
There was a problem hiding this comment.
Thanks @dylansdaniels for testing this out! @jashlu, as soon as you feel this is ready on your end, please update the title of this PR to "[MRG]..." to signal that it's on the final stage of review.
No description provided.