add vcxsrv script #341
add vcxsrv script #341
Conversation
| 1. Open the Command Prompt application. Can be found by searching `Command Prompt` in the Windows search bar. | ||
| 2. Paste the following command to install Windows Subsystem for Linux (WSL) | ||
| ``` | ||
| wsl --install |
There was a problem hiding this comment.
Is there a way to manually specify WSL2?
I think this is installed by default now but we've run into a few folks that had WSL1 and couldn't install docker
There was a problem hiding this comment.
Just for clarification, are u saying folks who already had WSL1 before attempting this installation process were having errors installing docker? Like you said, wsl --install should by default install WSL2 so users who are following this tutorial, starting from scratch, should have WSL2 installed.
I could add some additional instructions here on how to upgrade from WSL1 to WSL2 if that helps (and mention that WSL2 is required over WSL1)
There was a problem hiding this comment.
Perhaps we could just say something like:
Note: if WSL is already installed on your computer, please ensure it is WSL2 . WSL1 is incompatible with Docker install.
There was a problem hiding this comment.
Sounds good, i'll add that in
Co-authored-by: Nicholas Tolley <55253912+ntolley@users.noreply.github.com>
There was a problem hiding this comment.
Hey Josh, you've made a very elegant script there – it leverages you access to the place where the data are (the Linux VM) and automates the tricky Windows part!
I think you would be better served just deleting the old instructions which don't work any more. If you leave them in, people might be misled into thinking that they aren't broken. Don't be afraid to just delete stuff which isn't up to date – we have the history in Git after all.
Co-authored-by: John Gerrard Holland <john_holland1@brown.edu>
Co-authored-by: John Gerrard Holland <john_holland1@brown.edu>
Co-authored-by: John Gerrard Holland <john_holland1@brown.edu>
Co-authored-by: John Gerrard Holland <john_holland1@brown.edu>
But your insight/comments are nevertheless valuable! Thanks for taking a look |
hollandjg
dismissed
their stale review
Waiting for code owners to check. Looks good to me.
|
hi @ntolley – is this good to merge or do we need to do more here? |
|
Apologies @hollandjg testing this script got lost on my to-do list after the holiday break @dylansdaniels can we sit together to test out this script on your windows machine? |
|
@ntolley Yes we can definitely do that. I mostly copied/pasted the instructions from this file anyway when I recently tested install on my machine, but i was doing it line by line since i didn't have the file locally. I only deviated from the instructions in that I copied the IP address manually. |
Hi all, this PR includes the vcxsrv script that will automate the configs requried for VcXsrv. Also included is the updated README with instructions on running this script.
The same changes have been applied to the maint/pre-hnn-core PR.
Open to any suggestions/comments! Thanks