Fix gc of async destructuring assignments of strings #5126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes jerryscript-project#5089 When garbage collection is running on a paused async function that includes destructuring assignments of strings, the string can be a direct string, and not an object, which cannot be marked as visited, as it does not have a visited flag. JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
|
I am landing this. Something is off with the macOS tests, they should not be running for 6 hours when everything else is running under 6 minutes. |
akosthekiss
merged commit bac7ee3
into
jerryscript-project:master
25 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5089
When garbage collection is running on a paused async function that includes destructuring assignments of strings, the string can be a direct string, and not an object, which cannot be marked as visited, as it does not have a visited flag.