Skip to content

Commit

Permalink
Fix gc of async destructuring assignments of strings
Browse files Browse the repository at this point in the history
This fixes #5089

When garbage collection is running on a paused async function that
includes destructuring assignments of strings, the string can be a
direct string, and not an object, which cannot be marked as visited, as
it does not have a visited flag.

JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
  • Loading branch information
matetokodi committed Feb 5, 2024
1 parent 52debe8 commit cd79318
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
6 changes: 5 additions & 1 deletion jerry-core/ecma/base/ecma-gc.c
Expand Up @@ -742,7 +742,11 @@ ecma_gc_mark_executable_object (ecma_object_t *object_p) /**< object */

do
{
ecma_gc_set_object_visited (ecma_get_object_from_value (*(--context_top_p)));
--context_top_p;
if (ecma_is_value_object (*context_top_p))
{
ecma_gc_set_object_visited (ecma_get_object_from_value (*context_top_p));
}
} while (context_top_p > last_item_p);

continue;
Expand Down
27 changes: 27 additions & 0 deletions tests/jerry/regression-test-issue-5089.js
@@ -0,0 +1,27 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

async function test1() {
var a;
({k: a = await 1} = "XY");
}
test1();
gc();

async function test2() {
var a;
[a = await 1] = "";
}
test2();
gc();

0 comments on commit cd79318

Please sign in to comment.