Add support for environment variables in source and class text fields in the plugin's configuration #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the plugin's configuration
…irPaths() method and its calls
…ng class and sources paths
centic9
requested changes
Feb 17, 2017
| FilePath[] matchedClassDirs = {}; | ||
| if (run instanceof AbstractBuild) { | ||
| matchedClassDirs = resolveDirPaths((AbstractBuild) run, filePath, taskListener, classPattern); | ||
| } |
There was a problem hiding this comment.
Not sure about the Jenkins internas here, but shouldn't we keep the previous behaviour if run is not an AbstractBuild?
| FilePath[] matchedSrcDirs = {}; | ||
| if (run instanceof AbstractBuild) { | ||
| matchedSrcDirs = resolveDirPaths((AbstractBuild) run, filePath, taskListener, sourcePattern); | ||
| } |
|
Haven't wrote test yet. Planning to do that. |
|
@NonGrate are you still planning to finish the PR? I'd be glad to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've met the problem, that when environment variables are used in the JaCoCo configuration in Jenkins.
Exclusions variables is parsed and the value is sent to the JaCoCo report generation, but source and classes paths are passed to the report generation as strings.
This pull request fixes the bug and allows to use environment variables in the class paths and source paths test fields.
Here's the opened issue:
https://issues.jenkins-ci.org/browse/JENKINS-36168