Do not change job parameters with env variables #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment variables when expanded changed the job settings. It should only expand during the actual build, so that parameterized build jobs don't have to be reverted after every run. Moved expansion a bit earlier, so that the log messages contains the patterns when they have been expanded. Added a new testcase, that will fail without the changes to JacocoPublisher.java.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a re-implementation of PR #77, or at least parts of it. Seems like it was already implemented except that the log messages still contained the unexpanded patterns which was a bit confusing.
Environment variables when expanded changed the job settings.
It should only expand during the actual build, so that parameterized
builds don't have to be reverted after every run.
Moved expansion a bit earlier, so that the log messages contains
the patterns when they have been expanded.
Added a new testcase, that will fail without the changes to
JacocoPublisher.java.