fix(tests): Add contains_over_clause #848 #850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update to django 4.2 has broken the test suite with error AttributeError: 'ExtraJoinRestriction' object has no attribute 'contains_over_clause' The `contains_over_clause = False` attribute added to ExtraJoinRestriction solves the error.
This was referenced Apr 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
==========================================
- Coverage 95.81% 93.43% -2.39%
==========================================
Files 3 9 +6
Lines 454 731 +277
Branches 96 131 +35
==========================================
+ Hits 435 683 +248
- Misses 12 31 +19
- Partials 7 17 +10
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you for tracking this, I've integrated this in a separate PR based on this. Sorry for the wait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Django 4.2
Adding support for Django 4.2 broke some tests with this error
AttributeError: 'ExtraJoinRestriction' object has no attribute 'contains_over_clause'Tracking the source of the error I have found a change to
38 def split_having(self, negated=False):in django 4.1to
38 def split_having_qualify(self, negated=False, must_group_by=False):in django 4.2 which is causing the error.The
'contains_over_clause'Attribute Tells Django that this expression contains a Window expression. It’s used, for example, to disallow window function expressions in queries that modify data.Examples of what the OVER clause does can be seen in the postgres documentation.
Adding
contains_over_clause = FalsetoExtraJoinRestrictionallows the tests to run successfully.closes #848