Fix test failures against Django main
#852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update to django 4.2 has broken the test suite with error AttributeError: 'ExtraJoinRestriction' object has no attribute 'contains_over_clause' The `contains_over_clause = False` attribute added to ExtraJoinRestriction solves the error.
Also update actions/checkout to v3
to support Django 5.0. The _columns() versions are still retained for compatibility across Django versions. Ref: django/django@8b1ff0d
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
- Coverage 95.81% 93.48% -2.33%
==========================================
Files 3 9 +6
Lines 454 737 +283
Branches 96 161 +65
==========================================
+ Hits 435 689 +254
- Misses 12 31 +19
- Partials 7 17 +10
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
|
Thank you for the patches, I pulled these changes in (I went for removing Python 3.6 support outright, as its at EOL) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #851 (at least for now).
This is built on top of #850, and with a different approach for #847.