Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dac #793

Closed
wants to merge 13 commits into from
Closed

Add dac #793

wants to merge 13 commits into from

Conversation

ywpratama
Copy link

Required: write a single sentence that describes the changes made by this PR.

How to review

Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review:” and describe why.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 184 lines in your changes are missing coverage. Please review.

Project coverage is 91.6%. Comparing base (31d9c58) to head (464a0a3).
Report is 203 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #793     +/-   ##
=======================================
- Coverage   94.3%   91.6%   -2.8%     
=======================================
  Files         43      46      +3     
  Lines       3475    4513   +1038     
=======================================
+ Hits        3280    4137    +857     
- Misses       195     376    +181     
Files Coverage Δ
message_ix/tools/add_dac/__init__.py 0.0% <0.0%> (ø)

... and 39 files with indirect coverage changes

@glatterf42
Copy link
Member

glatterf42 commented Feb 28, 2024

Hi @ywpratama, just so you know: tutorial failures might not be caused by your new code here. There was a bug introduced with a recent version of plotnine. To remedy, you could e.g. replicate c796cc5. This is, however, only a temporary fix and if you don't mind the tutorials failing for now, some new version will probably fix the bug in the not-too-far future.

Same goes for individual tests that really look like they should be passing. We are currently trying to fix this flakiness in #784.

gidden added a commit to iiasa/message-ix-models that referenced this pull request Mar 21, 2024
@gidden
Copy link
Member

gidden commented Mar 21, 2024

closing in favor of #807

@gidden gidden closed this Mar 21, 2024
@gidden gidden mentioned this pull request Mar 28, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants