New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dac #793
Add dac #793
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
=======================================
- Coverage 94.3% 91.6% -2.8%
=======================================
Files 43 46 +3
Lines 3475 4513 +1038
=======================================
+ Hits 3280 4137 +857
- Misses 195 376 +181
|
Hi @ywpratama, just so you know: tutorial failures might not be caused by your new code here. There was a bug introduced with a recent version of plotnine. To remedy, you could e.g. replicate c796cc5. This is, however, only a temporary fix and if you don't mind the tutorials failing for now, some new version will probably fix the bug in the not-too-far future. Same goes for individual tests that really look like they should be passing. We are currently trying to fix this flakiness in #784. |
set node_rel and node_loc equal to fully reproduce results behaviour
add dacco2_tran_disp relation to dacco2_tr_dis
closing in favor of #807 |
Required: write a single sentence that describes the changes made by this PR.
How to review
Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review:” and describe why.
PR checklist