Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_dac #158

Closed
wants to merge 1 commit into from
Closed

add_dac #158

wants to merge 1 commit into from

Conversation

gidden
Copy link
Member

@gidden gidden commented Mar 21, 2024

This is a draft PR to implement technology-specific additions in this repo rather than message_ix. FYI @ywpratama

Initially, __init__.py is added from iiasa/message_ix#793

Required: write a single sentence that describes the changes made by this PR.

How to review

Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review:” and describe why.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@gidden gidden changed the title add init from https://github.com/iiasa/message_ix/pull/793 add_dac Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 175 lines in your changes are missing coverage. Please review.

Project coverage is 73.3%. Comparing base (583d3e9) to head (ae195f5).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #158     +/-   ##
=======================================
- Coverage   75.4%   73.3%   -2.1%     
=======================================
  Files         93      94      +1     
  Lines       6211    6386    +175     
=======================================
  Hits        4684    4684             
- Misses      1527    1702    +175     
Files Coverage Δ
message_ix_models/model/dac/__init__.py 0.0% <0.0%> (ø)

@glatterf42 glatterf42 added the enh New features or functionality label Mar 22, 2024
@gidden
Copy link
Member Author

gidden commented Mar 28, 2024

@glatterf42 - as discussed in iiasa/message_ix#807 if you could help us set up a docs landing page with tutorials, we can migrate the tutorial files in that PR into this one

@gidden
Copy link
Member Author

gidden commented Mar 28, 2024

Hi all - after further discussions with @ywpratma we decided to make his add_dac tool more generic and will open a different PR for that

@gidden gidden closed this Mar 28, 2024
@gidden gidden deleted the dac branch March 28, 2024 12:51
shaohuizhang pushed a commit to shaohuizhang/message-ix-models that referenced this pull request Apr 8, 2024
…s in tests (iiasa#158)

- Correct name format of xlsx file in test_report_bare
  Remove colon (:) from the name of the reporting file that was leading the test to fail in Windows in test_report_bare
- Correct typo in shell usage example
- Improve documentation for building a MESSAGEix-Transport model
- Expand transport usage docs
- Squash warnings in docs build

Co-authored-by: Paul Natsuo Kishimoto <mail@paul.kishimoto.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants