LDAP secrets engine enhancements #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add additional mount configuration parameters * Add method to rotate static role credentials manually * Update documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 87.80% 87.81% +0.01%
==========================================
Files 67 67
Lines 3264 3267 +3
==========================================
+ Hits 2866 2869 +3
Misses 398 398
|
briantist
approved these changes
Apr 18, 2024
briantist
added
enhancement
|
@mweigel excellent! thanks for this addition, it looks good to me and has coverage as well, we should be able to get this into 2.2.0 along with the initial LDAP support:
|
|
@mweigel Thanks for popping this in! All the changes look good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's great that the LDAP secrets engine has been added! This is a small update to add in a couple of bits of missing functionality.
Add additional mount configuration parameters
Add method to rotate static role credentials manually
Update documentation