Implement activedirectory.rotate_credentials and ldap.rotate_static_credentials

[hkgnobody]

usage: client.secrets.activedirectory.rotate_credentials(name,[mount_point])

[hkgnobody]

Ref: https://developer.hashicorp.com/vault/api-docs/secret/ad#rotate-role-credentials
https://developer.hashicorp.com/vault/api-docs/secret/ldap#manually-rotate-static-role-password

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.75%. Comparing base (a0418e2) to head (8058eb0).
Report is 1 commits behind head on main.

❗ Current head 8058eb0 differs from pull request most recent head 5756bb4. Consider uploading reports for the commit 5756bb4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
- Coverage   87.80%   87.75%   -0.06%     
==========================================
  Files          67       67              
  Lines        3264     3267       +3     
==========================================
+ Hits         2866     2867       +1     
- Misses        398      400       +2     

Files	Coverage Δ
hvac/api/secrets_engines/active_directory.py	39.39% <33.33%> (-0.61%)	⬇️

[Tylerlhess]

While this is a simple endpoint call passing to the api it might be worth a simple sanity check of a test case

[hkgnobody]

@Tylerlhess not sure if it is what you suggested to have.
Otherwise we can add another test to check the "last_password" after invoking rotate_credentials() is matching the "password" of the previous mocked request?

[hkgnobody]

I made a mistake. implemented active_directory but make test case on ldap. Convert to DRAFT.

[Tylerlhess]

@Tylerlhess not sure if it is what you suggested to have. Otherwise we can add another test to check the "last_password" after invoking rotate_credentials() is matching the "password" of the previous mocked request?

Yeah that would actually be a good test. I think of having a test, even a dumb one, is a good way to make sure that other changes don't break this function from even being called. Yes validating that it actually worked is important but even a simple test that it runs without error catches most breaking changes.

[hkgnobody]

I believe the ad and ldap are very similar. That's why in the code base, they are almost identical.
Therefore i am going to implement the rotate role credentials for both modules.
Test case on expeccted status code was added for ldap, but i cannot locate the test file for AD.

[hkgnobody]

I saw the ldap part was implemented in #1163, casuing a conflict. Going to pull out my changes.