2.x.x http2 idle state (version 2) #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #371 +/- ##
==========================================
+ Coverage 84.32% 84.42% +0.10%
==========================================
Files 95 95
Lines 5211 5253 +42
==========================================
+ Hits 4394 4435 +41
- Misses 817 818 +1 ☔ View full report in Codecov by Sentry. |
…ent timeouts Also include gracefulShutdown sequence to implement gracefulShutdown
adam-fowler
force-pushed
the
2.x.x-http2-idlestate-v2
branch
from
43d2d60
to
77de690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #370
Idle state is all done in the async handler. I merge the multiplexer inbound sequence and a async timer sequence together. I iterate over the elements of this merged sequence. For a stream event I start a a handle task for that stream, if a timer event occurs it checks how many streams are open and if the last stream to close was long enough ago. If so then it exits the loop and the channel is closed.
I also merge a gracefulShutdown AsyncStream with the two sequences above to implement graceful shutdown