Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x.x http2 idle state (version 1) #370

Open
wants to merge 4 commits into
base: 2.x.x
Choose a base branch
from

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Feb 2, 2024

I've implemented HTTP2 idle state using the IdleStateHandler and custom HTTP2 stream open and close events.
The idea being you shutdown when there are no open streams (it is up to the open streams to handle idle state) and an read idle event has been triggered.
The standard HTTP2 events are not generated by the channel handlers created by configureAsyncHTTPServerPipeline so I have to create custom events and pass them back to the channel as outbound events to say when streams open and close..

An alternative method can be found in #371

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (e13bb01) 84.32% compared to head (860010a) 83.96%.

Files Patch % Lines
...urces/HummingbirdHTTP2/HTTP2UserEventHandler.swift 61.11% 35 Missing ⚠️
Sources/HummingbirdHTTP2/HTTP2Channel.swift 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            2.x.x     #370      +/-   ##
==========================================
- Coverage   84.32%   83.96%   -0.37%     
==========================================
  Files          95       96       +1     
  Lines        5211     5312     +101     
==========================================
+ Hits         4394     4460      +66     
- Misses        817      852      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants