Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-17948 add Session.findAll(), StatelessSession.getAll() #8166
base: main
Are you sure you want to change the base?
HHH-17948 add Session.findAll(), StatelessSession.getAll() #8166
Changes from all commits
fb9f1af
ff43020
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just a convenience for
byMultipleIds(Class<?>).multiLoad(Object...)
? Maybe it's just me, but I don't think we should start "duplicating" API for convenience.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally very much agree with that. But I think a single convenience method for the common case is perfectly fine. Now if/when this starts getting overloaded, then I have a big problem with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also usually agree, but the thing is that JPA 3.2 has gone in a quite different direction with
FindOption
s.I initially proposed something more like our
XxxxLoadAccess
interfaces, but theXxxOptions
objects were the direction Lukas wanted to take, and he talked me into it. Ultimately I think this was the right choice.Therefore the concept here, as described in the issue, is that in H7 we would allow
findAll()
to acceptFindOption
s. Yes, it's still "duplication" in some sense, but justifiable duplication, I would say.