HHH-17948 add Session.findAll(), StatelessSession.getAll() #8166
Conversation
Signed-off-by: Gavin King <gavin@hibernate.org>
|
Minor comment, but looks reasonable otherwise |
| * | ||
| * @since 6.5 | ||
| */ | ||
| <E> List<E> findAll(Class<E> entityType, Object... ids); |
There was a problem hiding this comment.
So just a convenience for byMultipleIds(Class<?>).multiLoad(Object...)? Maybe it's just me, but I don't think we should start "duplicating" API for convenience.
There was a problem hiding this comment.
So just a convenience for
byMultipleIds(Class<?>).multiLoad(Object...)? Maybe it's just me, but I don't think we should start "duplicating" API for convenience.
I generally very much agree with that. But I think a single convenience method for the common case is perfectly fine. Now if/when this starts getting overloaded, then I have a big problem with this
There was a problem hiding this comment.
I also usually agree, but the thing is that JPA 3.2 has gone in a quite different direction with FindOptions.
I initially proposed something more like our XxxxLoadAccess interfaces, but the XxxOptions objects were the direction Lukas wanted to take, and he talked me into it. Ultimately I think this was the right choice.
Therefore the concept here, as described in the issue, is that in H7 we would allow findAll() to accept FindOptions. Yes, it's still "duplication" in some sense, but justifiable duplication, I would say.
Signed-off-by: Gavin King <gavin@hibernate.org>
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
https://hibernate.atlassian.net/browse/HHH-17948