Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: makes SelectMultiple accept undefined or null #6491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/js/components/SelectMultiple/SelectMultiple.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const SelectMultiple = forwardRef(
onOpen,
onSearch,
open: openProp,
options: optionsProp,
options: rawOptionsProp,
placeholder,
plain,
replace,
Expand All @@ -104,7 +104,7 @@ const SelectMultiple = forwardRef(
const selectBoxRef = useRef();
const dropButtonRef = useForwardedRef(ref);
const usingKeyboard = useKeyboard();

const optionsProp = useMemo(() => rawOptionsProp || [], [rawOptionsProp]);
// value is used for what we receive in valueProp and the basis for
// what we send with onChange
// When 'valueKey' sets 'reduce', the value(s) here should match
Expand Down