fix: makes SelectMultiple accept undefined or null #6491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
reviewed
Nov 14, 2022
There was a problem hiding this comment.
Nice work on this so far! I think it would be good to include a new storybook example that demonstrates one of the loading cases in the original issue.
When options is set to null or undefined the SelectMultiple shows 'No matches found' text at the bottom of the drop. I think we need to adjust the 'No matches found' to only show when we there is actually text in the search input.
|
Hi @BrunoViveiros just wanted to check in on this pull request. I think it is pretty close to the finish line and there are just a few things to tie off. Is this something that you are still interested in working on? |
jcfilben
added
the
needs attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes SelectMultiple accept undefined or null
Where should the reviewer start?
SelectMultiple component
What testing has been done on this PR?
not sure how to test when receiving undefined value
How should this be manually tested?
when passing a undefined value for
optionsit should not generate a errorDo Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
I'm not sure if I should create a new story showing a loading when the options are taking some time to fetch
What are the relevant issues?
closes #6351
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?