Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List component children not working with React 18 and typescript #6836

Open
AntoLC opened this issue Jun 8, 2023 · 2 comments · May be fixed by #7039
Open

List component children not working with React 18 and typescript #6836

AntoLC opened this issue Jun 8, 2023 · 2 comments · May be fixed by #7039
Assignees
@Sulaymon333
Labels
hacktoberfest PRs submitted in October (open-source celebration month) help wanted Would appreciate community help working on this typescript Typescript enhancements and bugs

Comments

@AntoLC
Copy link

AntoLC commented Jun 8, 2023

Actual Behavior

On the component <List />, the children ts interface is not correct with React 18, the code doesn't work.

Codepen exhibiting the issue

See by yourself on codesandbox.
@AntoLC AntoLC changed the title List component problem with React 18 and typescript List component children not working with React 18 and typescript Jun 8, 2023
AntoLC added a commit to openfun/marsha that referenced this issue Jun 8, 2023
@AntoLC
💩(frontend) issue ts with grommet component List
3f020cb 
The children prop of the List component from grommet is not typed
correctly.
An issue has been open on their repo:
grommet/grommet#6836
Here is a quick fix for the time being.
AntoLC added a commit to openfun/marsha that referenced this issue Jun 8, 2023
@AntoLC
💩(frontend) issue ts with grommet component List
758f575 
The children prop of the List component from grommet is not typed
correctly.
An issue has been open on their repo:
grommet/grommet#6836
Here is a quick fix for the time being.
AntoLC added a commit to openfun/marsha that referenced this issue Jun 9, 2023
@AntoLC
💩(frontend) issue ts with grommet component List
1466b67 
The children prop of the List component from grommet is not typed
correctly.
An issue has been open on their repo:
grommet/grommet#6836
Here is a quick fix for the time being.
@jcfilben
Copy link
Collaborator

jcfilben commented Jun 12, 2023 •
edited

Thanks for reporting, I think the type for children in List just needs updated. Similar issue: #6109

@jcfilben jcfilben added the typescript Typescript enhancements and bugs label Jun 12, 2023
AntoLC added a commit to openfun/marsha that referenced this issue Jun 13, 2023
@AntoLC
💩(frontend) issue ts with grommet component List
cfe867c 
The children prop of the List component from grommet is not typed
correctly.
An issue has been open on their repo:
grommet/grommet#6836
Here is a quick fix for the time being.
AntoLC added a commit to openfun/marsha that referenced this issue Jun 14, 2023
@AntoLC
💩(frontend) issue ts with grommet component List
d1b051e 
The children prop of the List component from grommet is not typed
correctly.
An issue has been open on their repo:
grommet/grommet#6836
Here is a quick fix for the time being.
@jcfilben jcfilben added the help wanted Would appreciate community help working on this label Jun 16, 2023
@AntoLC AntoLC mentioned this issue Jun 27, 2023
Merged
3 tasks
@jonscottclark
Copy link

@AntoLC Thank you so much for providing your workaround, it works for us! 🙏

@jcfilben jcfilben added the hacktoberfest PRs submitted in October (open-source celebration month) label Sep 19, 2023
@DavidMathevet DavidMathevet mentioned this issue Nov 8, 2023
Open
@Sulaymon333 Sulaymon333 linked a pull request Nov 29, 2023 that will close this issue
Open
3 tasks
@jcfilben jcfilben mentioned this issue Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sulaymon333 Sulaymon333

Labels
hacktoberfest PRs submitted in October (open-source celebration month) help wanted Would appreciate community help working on this typescript Typescript enhancements and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix List component children React 18 and typescript Sulaymon333/grommet
4 participants
@jonscottclark @AntoLC @Sulaymon333 @jcfilben