💩(frontend) issue ts with grommet component List

The children prop of the List component from grommet is not typed correctly. An issue has been open on their repo: grommet/grommet#6836 Here is a quick fix for the time being.
openfun · Jun 13, 2023 · cfe867c · cfe867c
1 parent b210cfb
commit cfe867c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/frontend/apps/lti_site/components/PlaylistPortability/index.tsx b/src/frontend/apps/lti_site/components/PlaylistPortability/index.tsx
@@ -3,7 +3,7 @@ import {
   Button,
   Form,
   FormField,
-  List,
+  ListExtendedProps,
   Spinner,
   Text,
   TextInput,
@@ -22,6 +22,10 @@ import {
 } from 'lib-components';
 import { usePlaylist, useUpdatePlaylist } from '../../data/queries';
 
+declare const List: <ListItemType = string | unknown>(
+  p: ListExtendedProps<ListItemType>,
+) => React.ReactElement<ListExtendedProps<ListItemType>>;
+
 const messages = defineMessages({
   loadingPlaylist: {
     defaultMessage: 'Loading playlist...',

diff --git a/src/frontend/packages/lib_video/src/components/live/common/ViewersList/index.tsx b/src/frontend/packages/lib_video/src/components/live/common/ViewersList/index.tsx
@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-unsafe-call */
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
-import { Box, Button, List, Paragraph } from 'grommet';
+import { Box, Button, ListExtendedProps, Paragraph } from 'grommet';
 import { normalizeColor } from 'grommet/utils';
 import { AddCircle } from 'grommet-icons';
 import { colors } from 'lib-common';
@@ -25,6 +25,10 @@ import {
   sortParticipantNotOnStage,
 } from './utils';
 
+declare const List: <ListItemType = string | unknown>(
+  p: ListExtendedProps<ListItemType>,
+) => React.ReactElement<ListExtendedProps<ListItemType>>;
+
 const messages = defineMessages({
   demands: {
     defaultMessage: 'Demands',