Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix List component children React 18 and typescript #7039

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sulaymon333
Copy link
Collaborator

What does this PR do?

This PR fixes List component children React 18 and typescript error

Where should the reviewer start?

What testing has been done on this PR?

How should this be manually tested?

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

What are the relevant issues?

Closes #6836

Screenshots (if appropriate)

Do the grommet docs need to be updated?

Yes

Should this PR be mentioned in the release notes?

Yes

Is this change backwards compatible or is it a breaking change?

Backward compatible

@britt6612
Copy link
Collaborator

britt6612 commented Nov 30, 2023

testing with this story

    <List data={data} pad="medium" border={false}>
      {(datum) => (
        <Tip content={datum.state} dropProps={{ align: { left: 'right' } }}>
          <Box direction="row-responsive" gap="medium" align="center">
            <Gremlin size="large" />
            <Text weight="bold">{datum.city}</Text>
          </Box>
        </Tip>
      )}
    </List>

looks like element is also missing in the TS

@jcfilben jcfilben added the waiting Awaiting response to latest comments label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Awaiting response to latest comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List component children not working with React 18 and typescript
3 participants