Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve handshake error handling #24

Merged
merged 4 commits into from Mar 26, 2024
Merged

feat: improve handshake error handling #24

merged 4 commits into from Mar 26, 2024

Commits on Mar 26, 2024

  1. feat: improve handshake error handling 

    When HelloReply's status is ERROR, throw an exception containing error
detail that can be handled by the caller.
    @jgiovaresco
    jgiovaresco committed Mar 26, 2024
    Copy the full SHA
    546d815 View commit details
    Browse the repository at this point in the history

  2. fix: check targetId before unregistering the connector 

    When the handshake has failed, the targetId is not defined, and the
removal was throwing a NullPointerException.
    @jgiovaresco
    jgiovaresco committed Mar 26, 2024
    Copy the full SHA
    9c108bb View commit details
    Browse the repository at this point in the history

  3. fix: do not log the error in the log informing retries have stop 

    This would prevent polluting the log. The caller would be able to create
its own log with the cause if wanted.
    @jgiovaresco
    jgiovaresco committed Mar 26, 2024
    Copy the full SHA
    d95bde7 View commit details
    Browse the repository at this point in the history

  4. fix: use default implementation for Command/Reply adapters declaration 

    Controllers may not need adapters for Command/Reply. Using a default
implementation in the interface simplifies the DX by avoiding to
implement those methods.
    @jgiovaresco
    jgiovaresco committed Mar 26, 2024
    Copy the full SHA
    1532880 View commit details
    Browse the repository at this point in the history