feat: improve handshake error handling #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiovaresco
force-pushed
the
improve-handshake-error-handling
branch
2 times, most recently
from
cb23a08
to
03088db
Compare
jgiovaresco
force-pushed
the
improve-handshake-error-handling
branch
from
03088db
to
d564e26
Compare
When HelloReply's status is ERROR, throw an exception containing error detail that can be handled by the caller.
When the handshake has failed, the targetId is not defined, and the removal was throwing a NullPointerException.
This would prevent polluting the log. The caller would be able to create its own log with the cause if wanted.
Controllers may not need adapters for Command/Reply. Using a default implementation in the interface simplifies the DX by avoiding to implement those methods.
jgiovaresco
force-pushed
the
improve-handshake-error-handling
branch
from
d564e26
to
1532880
Compare
guillaumelamirand
approved these changes
Mar 26, 2024
|
馃帀 This PR is included in version 1.1.0 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When HelloReply's status is ERROR, throw an exception containing error detail that can be handled by the caller.
Additional context
Gravitee.io Automatic Deployment
馃殌 A prerelease version of this package has been published on Gravitee's private artifactory, you can:
1.1.0-improve-handshake-error-handling-SNAPSHOT