Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate updateStrategy configuration for jobservice and registry deployments #1728

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Separate updateStrategy configuration for jobservice and registry deployments #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
332bb68
Separate updateStrategy type for jobservice and registry
jwojnarowicz Mar 11, 2024
ac4d7c3
readme values table update
jwojnarowicz Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -175,7 +175,8 @@ The following table lists the configurable parameters of the Harbor chart and th
| `uaaSecretName` | If using external UAA auth which has a self signed cert, you can provide a pre-created secret containing it under the key `ca.crt`. | |
| `imagePullPolicy` | The image pull policy | |
| `imagePullSecrets` | The imagePullSecrets names for all deployments | |
| `updateStrategy.type` | The update strategy for deployments with persistent volumes(jobservice, registry): `RollingUpdate` or `Recreate`. Set it as `Recreate` when `RWM` for volumes isn't supported | `RollingUpdate` |
| `updateStrategy.jobservice.type` | The update strategy for jobservice deployment with persistent volume: `RollingUpdate` or `Recreate`. Set it as `Recreate` when `RWM` for volumes isn't supported | `RollingUpdate` |
| `updateStrategy.registry.type` | The update strategy for registry deployment with persistent volume: `RollingUpdate` or `Recreate`. Set it as `Recreate` when `RWM` for volumes isn't supported | `RollingUpdate` |
| `logLevel` | The log level: `debug`, `info`, `warning`, `error` or `fatal` | `info` |
| `harborAdminPassword` | The initial password of Harbor admin. Change it from portal after launching Harbor | `Harbor12345` |
| `existingSecretAdminPassword` | The name of secret where admin password can be found. | |
Expand Down
4 changes: 2 additions & 2 deletions templates/jobservice/jobservice-dpl.yaml
View file
Open in desktop
Expand Up @@ -9,8 +9,8 @@ spec:
replicas: {{ .Values.jobservice.replicas }}
revisionHistoryLimit: {{ .Values.jobservice.revisionHistoryLimit }}
strategy:
type: {{ .Values.updateStrategy.type }}
{{- if eq .Values.updateStrategy.type "Recreate" }}
type: {{ .Values.updateStrategy.jobservice.type }}
{{- if eq .Values.updateStrategy.jobservice.type "Recreate" }}
rollingUpdate: null
{{- end }}
selector:
Expand Down
4 changes: 2 additions & 2 deletions templates/registry/registry-dpl.yaml
View file
Open in desktop
Expand Up @@ -11,8 +11,8 @@ spec:
replicas: {{ .Values.registry.replicas }}
revisionHistoryLimit: {{ .Values.registry.revisionHistoryLimit }}
strategy:
type: {{ .Values.updateStrategy.type }}
{{- if eq .Values.updateStrategy.type "Recreate" }}
type: {{ .Values.updateStrategy.registry.type }}
{{- if eq .Values.updateStrategy.registry.type "Recreate" }}
rollingUpdate: null
{{- end }}
selector:
Expand Down
5 changes: 4 additions & 1 deletion values.yaml
View file
Open in desktop
Expand Up @@ -347,7 +347,10 @@ imagePullSecrets:
# The update strategy for deployments with persistent volumes(jobservice, registry): "RollingUpdate" or "Recreate"
# Set it as "Recreate" when "RWM" for volumes isn't supported
updateStrategy:
type: RollingUpdate
jobservice:
type: RollingUpdate
registry:
type: RollingUpdate

# debug, info, warning, error or fatal
logLevel: info
Expand Down