Separate updateStrategy configuration for jobservice and registry deployments #1728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am happy to share me Pull Request that addresses issues I encountered during working with Harbor Helm.
What improvements does these changes make?
jobservice
andregistry
,s3
like backend, there is no need to change the strategy toRecreate
as it does not depend onPVC
andRWM/RWO
access,Recreate
strategy for jobservice running on PVC inRWO
and at the same time does not usePVC
for registry storage, thenRecreate
creates unavailability of registry pods during update even though there is no such need.I have also changed the README.md to reflect the changes.
If you prefer I can also put these options inside
jobservice
andregistry
options then it would bejobservice.updateStrategy.type
instead (and same for registry).Cheers 馃槃