Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate updateStrategy configuration for jobservice and registry deployments #1728

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jwojnarowicz
Copy link

Hello,

I am happy to share me Pull Request that addresses issues I encountered during working with Harbor Helm.

What improvements does these changes make?

  • Adds separation between update strategies for both persistent volume dependent deployments - jobservice and registry,
  • When someone uses s3 like backend, there is no need to change the strategy to Recreate as it does not depend on PVC and RWM/RWO access,
  • When someone still has to use Recreate strategy for jobservice running on PVC in RWO and at the same time does not use PVC for registry storage, then Recreate creates unavailability of registry pods during update even though there is no such need.

I have also changed the README.md to reflect the changes.
If you prefer I can also put these options inside jobservice and registry options then it would be jobservice.updateStrategy.type instead (and same for registry).

Cheers 馃槃

Signed-off-by: jwojnarowicz <yakub.wojnarowicz@gmail.com>
Signed-off-by: jwojnarowicz <yakub.wojnarowicz@gmail.com>
@jwojnarowicz
Copy link
Author

@MinerYang can you check?

@MinerYang MinerYang self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants