Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Add external proxy option #1494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat:Add external proxy option #1494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/nginx/configmap-http.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
{{- if and (ne .Values.expose.type "ingress") (not .Values.expose.tls.enabled) }}
{{- if and (ne .Values.expose.type "ingress") (ne .Values.expose.type "external") (not .Values.expose.tls.enabled) }}
{{- $scheme := (include "harbor.component.scheme" .) -}}
apiVersion: v1
kind: ConfigMap
Expand Down
2 changes: 1 addition & 1 deletion templates/nginx/configmap-https.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
{{- if and (ne .Values.expose.type "ingress") .Values.expose.tls.enabled }}
{{- if and (ne .Values.expose.type "ingress") (ne .Values.expose.type "external") .Values.expose.tls.enabled }}
{{- $scheme := (include "harbor.component.scheme" .) -}}
apiVersion: v1
kind: ConfigMap
Expand Down
2 changes: 1 addition & 1 deletion templates/nginx/deployment.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
{{- if ne .Values.expose.type "ingress" }}
{{- if and (ne .Values.expose.type "ingress") (ne .Values.expose.type "external") }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
4 changes: 2 additions & 2 deletions values.yaml
View file
Open in desktop
@@ -1,5 +1,5 @@
expose:
# Set how to expose the service. Set the type as "ingress", "clusterIP", "nodePort" or "loadBalancer"
# Set how to expose the service. Set the type as "ingress", "clusterIP", "nodePort", "loadBalancer" or "external" if not using nginx
# and fill the information in the corresponding section
type: ingress
tls:
Expand Down Expand Up @@ -396,7 +396,7 @@ enableMigrateHelmHook: false
# contains a base64 encoded CA Certificate named `ca.crt`.
# uaaSecretName:

# If service exposed via "ingress", the Nginx will not be used
# If service exposed via "ingress" or "external", the Nginx will not be used
nginx:
image:
repository: goharbor/nginx-photon
Expand Down