Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Add external proxy option #1494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CloudlightCoUk
Copy link

The Harbor architecture describes a Proxy layer, but the Helm chart doesn't allow for that layer to be provided by anything other than nginx, with either an nginx object being created if the expose type is "ingress", or nginx itself being deployed if set to anything else.

I would like to extend the functionality to be able to 'bring my own proxy', in my case I want to use Contour with HTTPproxy objects. Rather than implement support for this in Harbor, it is easier simply to implement and expose option of 'external' where the chart can assume the proxy deployment is handled elsewhere. In this case no nginx deployment or object creation is triggered by the chart.

Allows the option to not deploy nginx for bringing your own proxn

Signed-off-by: Steve Morris <morrisst@vmware.com>
@Vad1mo
Copy link
Member

Vad1mo commented May 12, 2023

same as #1073, I would prefer the notion of expose.enabled=true/flase as this is more common Helm Chart development practice. Where external isn't.

@CloudlightCoUk
Copy link
Author

I saw #1073, but it hasn't moved in a year, so thought I'd share what I have done.

I'm not massively opinionated on the implementation, but do feel strongly that as Harbor is a layered architecture, we should have flexibility on the proxy we use, just as we do the storage/db/cache, we use. Especially as nginx is becoming less popular for proxy/ingress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants