feat(trivy): allow to give trivy github token via secret #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting the trivy github token via a parameter in the helm chart, provide the ability to give it via an existing secret. Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
|
@zyyw , @MinerYang can you take a look? |
would love to have this. When can we expect some movement? |
zyyw
approved these changes
Jan 12, 2023
|
closing it and then reopen it to trigger ci |
zyyw
reviewed
Jan 12, 2023
| @@ -1,4 +1,4 @@ | |||
| # Helm Chart for Harbor | |||
| ****# Helm Chart for Harbor | |||
There was a problem hiding this comment.
@sylvainOL , could you please justify why we need change of this line? Could you please remove the change regarding this line, thanks
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the trivy github token via a parameter in the helm chart,
provide the ability to give it via an existing secret.