Allow to give admin password via secret #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zyyw , @MinerYang can you take a look? |
pitwegner
suggested changes
Oct 10, 2022
sylvainOL
commented
Oct 10, 2022
Instead of setting the admin password via a parameter in the helm chart, provide the ability to give it via an existing secret. Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
sylvainOL
force-pushed
the
harbor-admin-password
branch
from
764e32f
to
18399c7
Compare
|
@pitwegner any movement on this? We would really like this feature as well. |
|
@rdelpret I'm not related to the goharbor project at all, I just added my 2 cents to the PR because I'm interested in the feature as well |
|
@MinerYang @zyyw Any movement on this? also looking for any help with maintaining this chart? |
|
closing it and then reopen it to run the ci |
zyyw
approved these changes
Jan 12, 2023
|
closing and reopen this PR to re-run the ci. |
ywk253100
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the admin password via a parameter in the helm chart,
provide the ability to give it via an existing secret.