New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Tests for Harbor CLI #23
Comments
Not a bad idea. |
regarding ginko and BDD, I wonder if that is not too much added complexity for the project? and we should stikc what golang provides |
Using Ginkgo and BDD for Harbor CLI tests can add complexity. Sticking with standard Go testing if the project is simple. But for complex projects, Ginkgo offers clearer tests, better collaboration. [ Updated the Description ] |
Specifically for harbor-cli it'd be better to stick with standard go test IMO which will also be helpful for codecov integration |
Hi! Is this project open for external contributors? Not exactly E2E, but I had noticed that the credential store has no associated tests with it. I would love to try o add a test suite for the same. |
Sure go ahead! |
I noticed there are no unit tests in this repo, can I go ahead and create a PR for the same? |
sure @criticic |
End-to-end tests are essential for ensuring the quality of Harbor CLI features
Implementation
Using Ginkgo and BDD for Harbor CLI tests can add complexity. Sticking with standard Go testing if the project is simple. But for complex projects, Ginkgo offers clearer tests, better collaboration.
Note: If you have alternative suggestions for constructing end-to-end tests for Harbor, please feel free to share your thoughts below.
// @OrlinVasilev @Vad1mo
The text was updated successfully, but these errors were encountered: