Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests for Harbor CLI #23

Open
amands98 opened this issue Feb 18, 2024 · 8 comments
Open

E2E Tests for Harbor CLI #23

amands98 opened this issue Feb 18, 2024 · 8 comments

Comments

@amands98
Copy link
Contributor

amands98 commented Feb 18, 2024

End-to-end tests are essential for ensuring the quality of Harbor CLI features

Implementation

  1. We can use ginkgo + gomega
  • adopting a Behavior-Driven Development (BDD) approach.
  • proven effective in various CLI projects, such as kubectl.
  1. Standard Go testing framework to test the functionality of a CLI tool.

Using Ginkgo and BDD for Harbor CLI tests can add complexity. Sticking with standard Go testing if the project is simple. But for complex projects, Ginkgo offers clearer tests, better collaboration.

Note: If you have alternative suggestions for constructing end-to-end tests for Harbor, please feel free to share your thoughts below.

// @OrlinVasilev @Vad1mo

@Vad1mo
Copy link
Member

Vad1mo commented Feb 19, 2024

Not a bad idea.

@Vad1mo
Copy link
Member

Vad1mo commented Feb 23, 2024

regarding ginko and BDD, I wonder if that is not too much added complexity for the project? and we should stikc what golang provides

@amands98
Copy link
Contributor Author

Using Ginkgo and BDD for Harbor CLI tests can add complexity. Sticking with standard Go testing if the project is simple. But for complex projects, Ginkgo offers clearer tests, better collaboration.

[ Updated the Description ]

@bishal7679
Copy link

Specifically for harbor-cli it'd be better to stick with standard go test IMO which will also be helpful for codecov integration

@EshaanAgg
Copy link
Contributor

Hi! Is this project open for external contributors? Not exactly E2E, but I had noticed that the credential store has no associated tests with it. I would love to try o add a test suite for the same.

@Vad1mo
Copy link
Member

Vad1mo commented Mar 5, 2024

Hi! Is this project open for external contributors? Not exactly E2E, but I had noticed that the credential store has no associated tests with it. I would love to try o add a test suite for the same.

Sure go ahead!

@criticic
Copy link

I noticed there are no unit tests in this repo, can I go ahead and create a PR for the same?

@Vad1mo
Copy link
Member

Vad1mo commented May 10, 2024

sure @criticic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants