Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added test for utils and login #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bishal7679
Copy link

Fixes parts of #23

  • Added the test files for utils.go (78.9%) and login.go (60%) test coverage
  • used mock server for testing purpose with stretchr/testify package

Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
@bishal7679
Copy link
Author

@Vad1mo PTAL here!

@Vad1mo
Copy link
Member

Vad1mo commented Apr 24, 2024

=== RUN TestGetClientByCredentialName
no credential found for the name: 127.0.0.1-testuser, please login again with the credential name: 127.0.0.1-testuser

@Vad1mo
Copy link
Member

Vad1mo commented Apr 24, 2024

The testcase TestGetClientByCredentialName should be able to run github actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants