Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added tests for the pkg/utils/config.go file #43

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

criticic
Copy link

@criticic criticic commented May 11, 2024

  • Adds unit tests for the pkg/utils/config.go file
  • Improves code coverage of utils package from 0% to 44% 46.4%

Related to #23

Signed-off-by: Sagnik Mandal <acriticalcynic@outlook.com>
@criticic
Copy link
Author

@Vad1mo Kindly take a look, and let me know if I should make any changes.

…ected

Signed-off-by: Sagnik Mandal <acriticalcynic@outlook.com>
Signed-off-by: Sagnik Mandal <acriticalcynic@outlook.com>
@criticic
Copy link
Author

Added tests for some more conditions, now the total coverage of utils pkg has improved from 0 to 46.4%

Copy link
Contributor

@amands98 amands98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we've changed a lot of code, can you update the test here?

@criticic
Copy link
Author

Sure, I'll make the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants