Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues Stream: Update assignee selector to use new design #69827

Open
Tracked by #69051
malwilley opened this issue Apr 26, 2024 · 0 comments
Open
Tracked by #69051

Issues Stream: Update assignee selector to use new design #69827

malwilley opened this issue Apr 26, 2024 · 0 comments
Assignees

Comments

@malwilley
Copy link
Member

malwilley commented Apr 26, 2024

After the work in #69054 we will have a new assignee selector that looks similar to the old one but with a new dropdown component.

The next step will be to update the trigger to match the new pill design, as pictured below. The component should receive a prop that will either display the trigger with or without text. For the first iteration, we will not display the assignee text on the issue stream.

CleanShot 2024-04-26 at 15 59 36

MichaelSun48 added a commit that referenced this issue May 6, 2024
This PR adds a `borderStyle` prop to the `<Tag/>` component. It is set
to `solid` by default, since that is what was the only option before.

This will be needed in upcoming changes to the Assignee dropdown trigger
on the Issue details page, detailed
[here](#69827)
MichaelSun48 added a commit that referenced this issue May 10, 2024
…selector trigger (#70561)

This PR creates a new component `<AssigneeBadge/>` which will eventually
replace the current assignee selector trigger in the issue stream. This
PR does **not** make any changes to the selector, it merely creates the
component and a corresponding storybook entry so it can be iterated on
independent of any changes made to the issue stream.

More details of the project can be found
[here](#69827) (#69827)

At a glance (as of 5/9):
<img width="206" alt="image"
src="https://github.com/getsentry/sentry/assets/55160142/9da5fa59-4cc0-4dcf-be27-b7fcc5c686e3">

Note that unlike the previous assignee selector, there is no longer a
"Suggested Assignee" state for this new assignee selector, there is only
an Assigned and Unassigned state.

TODO:
- [x] Figure out what the loading state looks like
- [x] Chevron weight and style match border
- [x] Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants