-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(assignee-selector): Create storybook component for new assignee selector trigger #70561
Conversation
// Team avatars need extra left padding since the square avatar | ||
// is being fit into a rounded edge | ||
css={css` | ||
--avatar-spacing: ${space(0.5)} ${space(0.25)} ${space(0.5)} | ||
${assignedTo.type === 'team' ? space(0.75) : space(0.5)}; | ||
`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this still work for the suspect commit suggested assignee?
@roggenkemper This is not 100% set in stone though, so we can discuss this further if you have strong opinions |
maybe this is just me but i feel like the padding between the avatar and the name could be increased a bit |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This PR creates a new component
<AssigneeBadge/>
which will eventually replace the current assignee selector trigger in the issue stream. This PR does not make any changes to the selector, it merely creates the component and a corresponding storybook entry so it can be iterated on independent of any changes made to the issue stream.More details of the project can be found here (#69827)
At a glance (as of 5/9):
Note that unlike the previous assignee selector, there is no longer a "Suggested Assignee" state for this new assignee selector, there is only an Assigned and Unassigned state.
TODO: