feat(tags): Adds border customizability to <Tag/> #70269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
commented
May 3, 2024
static/app/components/badge/tag.tsx
Outdated
| @@ -18,6 +18,7 @@ import type {Color} from 'sentry/utils/theme'; | |||
| import theme from 'sentry/utils/theme'; | |||
|
|
|||
| export interface TagProps extends React.HTMLAttributes<HTMLSpanElement> { | |||
| borderStyle?: 'solid' | 'dashed' | 'dotted' | 'double' | 'none'; | |||
There was a problem hiding this comment.
There are more border styles than this, but I just added the 2d ones that I thought were relevant - feel free to correct me if there's a better way to do this
There was a problem hiding this comment.
Removed double because it doesn't appear to do anything.
Removed none because it just becomes text at that point
|
Is there a good way to write a test for this? I couldn't get |
ryan953
reviewed
May 3, 2024
There was a problem hiding this comment.
A note in the story could be useful https://sentry.sentry.io/stories/?name=app/components/badge/tag.stories.tsx
|
Updated stories page: |
ryan953
approved these changes
May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
borderStyleprop to the<Tag/>component. It is set tosolidby default, since that is what was the only option before.This will be needed in upcoming changes to the Assignee dropdown trigger on the Issue details page, detailed here