Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport ForceTorque system: improve readability (#2403) #2405

Merged
merged 1 commit into from
May 14, 2024

Conversation

scpeters
Copy link
Member

馃 Bug fix

Backport of #2403 to Garden

Summary

Original description:

This adds some comments and uses structured bindings in range-based for loops to improve readability. It also adds const to unmodified variables in a loop.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Rebase-and-Merge.

This adds some comments and uses structured bindings
in range-based for loops to improve readability.
It also adds const to unmodified variables in a loop.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from mjcarroll as a code owner May 14, 2024 08:16
@github-actions github-actions bot added the 馃尡 garden Ignition Garden label May 14, 2024
@scpeters scpeters merged commit a8f99a9 into gz-sim7 May 14, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/force_torque_readability_7 branch May 14, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃尡 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants